Use porting::optional in olp-cpp-sdk-write instead of boost::optional. #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, SDK requires C++11 minimum. So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit is a second part of the task: olp-cpp-sdk-write. Relates-To: NLAM-23 Signed-off-by: sopov <ext-alexander.sopov@here.com>
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
from
00ba6c9 to
95a7eb4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1626 +/- ##
==========================================
- Coverage 80.29% 80.29% -0.00%
==========================================
Files 349 349
Lines 13941 13944 +3
Branches 1492 1491 -1
==========================================
+ Hits 11193 11195 +2
- Misses 2148 2150 +2
+ Partials 600 599 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrey-kashcheev
previously approved these changes
Aug 8, 2025
Collaborator
|
it make sense to give PR's name depending on the content, not very hard but will make it easier to find something in future |
Currently, SDK requires C++11 minimum. So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit is a second part of the task: olp-cpp-sdk-write. Relates-To: NLAM-23 Signed-off-by: sopov <ext-alexander.sopov@here.com>
asopov-here
changed the title
rustam-gamidov-here
approved these changes
Aug 8, 2025
andrey-kashcheev
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit is a second part of the task: olp-cpp-sdk-write.
Relates-To: NLAM-23